topic Re: Populating in/out parameters using CallActivityParseHandler in Alfresco Archive

Populating in/out parameters using CallActivityParseHandler

gokceng1 — Wed, 18 Dec 2013 08:59:36 GMT

Hello,Till this day, I've used parse handlers to assign listeners to the different types of activities. I've tried to add some io parameters to a call activity while parsing:@Overrideprotected void executeParse(BpmnParse bpmnParse, CallActivity callActivity) { super.executeParse(bpmnParse, callAct

Re: Populating in/out parameters using CallActivityParseHandler

jbarrez — Wed, 18 Dec 2013 09:51:26 GMT

What you could do alternatively, is override the default parse handler

see http://activiti.org/userguide/index.html#advanced_parseHandlers

<code>
It is possible (but less common) to replace the default BpmnParseHandler instances that are responsible for the parsing of the BPMN 2.0 elements to the internal Activiti model. This can be done by following snippet of logic:

<property name="customDefaultBpmnParseHandlers">
<list>
…
</list>
</property>
</code>

This effectively allows you to replace the default parse handler with your own. Which, if I understand your use case, is probably what you want/need.

Re: Populating in/out parameters using CallActivityParseHandler

gokceng1 — Wed, 18 Dec 2013 11:42:29 GMT

Hi Joram,
In fact I'm following that path currently:


public class CallActivityParseHandler extends org.activiti.engine.impl.bpmn.parser.handler.CallActivityParseHandler {
…
 @Override
 protected void executeParse(BpmnParse bpmnParse, CallActivity callActivity) {
  super.executeParse(bpmnParse, callActivity);
  initInOutParameters(callActivity);
 }
}
…


<bean id="parserProcessEngineConfiguration" parent="mailDisabledProcessEngineConfiguration">
 <property name="customDefaultBpmnParseHandlers">
  <list>
   <bean class="my.pkg.CallActivityParseHandler">
   </bean>
  </list>
 </property>
</bean>

Though this is not working for me. because super.executeParse(bpmnParse, callActivity); populates the io parameters beforehand. Even I update/create io paramaters in initInOutParameters(callActivity);, they aren't reflected to the CallActivityBehavior's dataInputAssociations.

What do you think?

Re: Populating in/out parameters using CallActivityParseHandler

jbarrez — Thu, 19 Dec 2013 11:04:07 GMT

I'm still not 100% sure if I understand you correctly.

But the code for call activity parse handler is this:

<code>
protected void executeParse(BpmnParse bpmnParse, CallActivity callActivity) {

    ActivityImpl activity = createActivityOnCurrentScope(bpmnParse, callActivity, BpmnXMLConstants.ELEMENT_CALL_ACTIVITY);
    activity.setScope(true);
    activity.setActivityBehavior(bpmnParse.getActivityBehaviorFactory().createCallActivityBehavior(callActivity));
}
</code>

Isn't it easier to just copy paste that in your custom one, store the result of the

<code>
bpmnParse.getActivityBehaviorFactory().createCallActivityBehavior(callActivity)
</code>

locally and do the adjustments?

Other angle to this problem might be both customizing the parse handler and the activityBehaviourFactory.

Re: Populating in/out parameters using CallActivityParseHandler

gokceng1 — Thu, 19 Dec 2013 14:39:10 GMT

Hi Joram,
Thank you for reply. I did it just like you said. It is working now. The thing that I don't like is being on guard against changes that can happen in next versions. If you change the internal mechanism, I will have to update it accordingly.
The problem is solved on my side but you may think the custom bpmn parse handlers for your next versions.

Thank you again.

Re: Populating in/out parameters using CallActivityParseHandler

jbarrez — Thu, 19 Dec 2013 15:58:10 GMT

You are correct. Altough i don't see yet how that could be done generically and easily … yet