topic [Issue] TaskCandidateQuery uses different group id from TaskCandidateGroup in Alfresco Archive

[Issue] TaskCandidateQuery uses different group id from TaskCandidateGroup

cfitch — Thu, 02 May 2013 15:39:14 GMT

Greetings, I'm having an issue with the Vacation Request example and taskCandidateUser/Group Queries.Env:Grails 2.2.1, JDK 1.6, Activiti Plugin 5.10, Shiro Plugin 1.14DescriptionI installed the Activiti Plugin and followed the code for another plugin in order to integrate wth Shiro. I've installed t

Re: [Issue] TaskCandidateQuery uses different group id from TaskCandidateGroup

cfitch — Thu, 02 May 2013 16:16:11 GMT

Here's additional info:
The user class:
<code>
/**
* Base class for Users in the system
*/
class WMSUser implements org.activiti.engine.identity.User
{
    // Added for activiti
    String id;

    String username;
    String passwordHash;
    String emailAddress;

    String firstName;
    String lastName;
    String name;

    ContactInfo contactInfo;

    Date dateCreated;
    Date lastUpdated;

    static hasMany = [ roles: WMSRole, permissions: String ];
    static mapping =
    {
        tablePerHierarchy false;
    }
    static mappedBy = [ ];

    static transients = [ 'email','password' ];

    static constraints =
    {
        username(nullable: false, blank: false, unique: true);
        contactInfo(nullable: true);
        password(nullable: true);
        email(nullable: true);
        firstName(nullable: true);
        lastName(nullable: true);
        name(nullable: true);
    }

    String getFirstName()
    {
        return name;
    }

    String getLastName()
    {
        return name;
    }

    String getEmail()
    {
        return emailAddress;
    }

    void setEmail(String email)
    {
        emailAddress;
    }

    String getPassword()
    {
        return "";
    }

    void setPassword(String password)
    {
    }

    Set<WMSRole> getAuthorities()
    {
        log.debug("[getAuthorities()]:");
        return roles as Set;
    }

    String getUserRoleName()
    {
        if(roles)
        {
            return ((WMSRole[])roles)[0].name;
        }
        else
        {
            return null;
        }
    }

}
</code>

Here's the role:
<code>
/**
* Base class for Roles in the system
*/
class WMSRole implements org.activiti.engine.identity.Group
{
    // added for activiti
    String id;
    String type;

    String name;
    String description;
    Date dateCreated;
    Date lastUpdated;


    static hasMany = [ users: WMSUser, permissions: String ];
    static belongsTo = [WMSUser];

    static constraints =
    {
        name(nullable: false, blank: false, unique: true);
        type(nullable: true);
    }

    WMSRole(String newName, String newDescription)
    {
        this.name = newName;
        this.description = newDescription;
    }
}
</code>

Re: [Issue] TaskCandidateQuery uses different group id from TaskCandidateGroup

cfitch — Thu, 02 May 2013 16:20:03 GMT

One Correction: taskCandidateQuery should be taskCandidateUser query. Apologies for the typo.

Re: [Issue] TaskCandidateQuery uses different group id from TaskCandidateGroup

cfitch — Thu, 02 May 2013 19:17:30 GMT

Update: the issue is related to the fact that taskCandidateUser calls getGroupsForCandidateUser(). In that method, it generates the list of groups for the user by calling
groupIds.add(group.getId());

The relevant code from TaskQueryImpl.java
<code>
protected List<String> getGroupsForCandidateUser(String candidateUser) {
    // TODO: Discuss about removing this feature? Or document it properly and maybe recommend to not use it
    // and explain alternatives
    List<Group> groups = Context
      .getCommandContext()
      .getGroupManager()
      .findGroupsByUser(candidateUser);
    List<String> groupIds = new ArrayList<String>();
    for (Group group : groups) {
      groupIds.add(group.getId());
    }
    return groupIds;
}
</code>

Since the id's for my groups (really Shiro roles) are Grails generated Id's eg. numbers, the list passed in to the SQL is correct. However, since the GROUP_ID column in ACT_RU_IDENTITYLINK table contains the group names, the query will return null.

So why are the names being stored in the ACT_RU_IDENTITYLINK table? Shouldn't those be the id's of the groups?

Re: [Issue] TaskCandidateQuery uses different group id from TaskCandidateGroup

jbarrez — Mon, 06 May 2013 09:23:09 GMT

They should be id's. But by coincidence (in the demo data) the name and id are the same.

So are you sure that always the name is stored? Cause that would really be a bug!

Re: [Issue] TaskCandidateQuery uses different group id from TaskCandidateGroup

cfitch — Mon, 06 May 2013 17:00:10 GMT

I noticed that as well and I changed my test groups to have id's matching the group names and everything started working correctly. I can't answer if they are always being stored as names but I'm pretty certain there is some issue. I also ran in to a similar issue with user id's and names with a taskAssignee query.

I don't have much time right now but I'll see if I can create some test code in order to recreate the issue.

Re: [Issue] TaskCandidateQuery uses different group id from TaskCandidateGroup

benwilson — Thu, 20 Jun 2013 19:59:08 GMT

Is there a way to configure activiti to use group names instead of IDs? We use UUIDs in our grails app, and putting UUIDs into the workflow instead of group names is just stupid.

Re: [Issue] TaskCandidateQuery uses different group id from TaskCandidateGroup

jbarrez — Mon, 24 Jun 2013 08:50:49 GMT

You can tweak the GroupManager to facilitate that. Check the activiti-ldap source code to get an idea of how you can do that.