topic Re: Task Priority values in Alfresco Archive

Task Priority values

brianshowers — Thu, 28 Feb 2013 19:13:31 GMT

Is there a reason why the Java comments state that Task Priority is limited to the range of [0,100]? As far as I can tell, it's only used for querying, and it looks like any integer value is supported from a persistence standpoint and query perspective. I also looked for usages of Task.PRIORITY_MI

Re: Task Priority values

jbarrez — Thu, 28 Feb 2013 19:32:07 GMT

No, it is indeed not checked or anything. You can pass whatever you want.

Re: Task Priority values

brianshowers — Thu, 28 Feb 2013 19:37:43 GMT

Would you consider removing the doc references to the [0,100] range in the 5.12 release? I'm a bit nervous about building functionality that explicitly violates the API contract. If I start doing that, and some later Activiti release starts to enforce the [0,100] limit, I'll be the one who is out of compliance. If the next version of Activiti will make support for arbitrary integer values explicit, I'll feel a lot better that I'm not coloring outside of the lines.

If you're ok with that, I'll open a Jira issue.

Re: Task Priority values

frederikherema1 — Fri, 01 Mar 2013 09:06:02 GMT

The values are actually used:


 public int getPriority() {
    String value = getValue().toString();
    if (i18nManager.getMessage(Messages.TASK_PRIORITY_LOW).equals(value)) {
      return Task.PRIORITY_MINIUM;
    } else if (i18nManager.getMessage(Messages.TASK_PRIORITY_MEDIUM).equals(value)) {
      return Task.PRIORITY_NORMAL;
    } else {
      return Task.PRIORITY_MAXIMUM;
    }
  }

There isn't any explicit reference in the docs stating that these are minimum and maximum values, but I can understand that it's confusing. I'll see whats the best way to resolve this confusement.

Re: Task Priority values

frederikherema1 — Fri, 01 Mar 2013 09:27:01 GMT

Deprecated the constants and moved to explorer:

https://github.com/Activiti/Activiti/commit/fb5caea787457032c66039113350a84eaf67b274

Re: Task Priority values

brianshowers — Fri, 01 Mar 2013 15:19:06 GMT

Thanks for making the change! I feel much better about using priority to store values from MIN_INT to MAX_INT now. I had only looked in the engine module when I searched for references. Sorry about that.

Note that you might also want to remove the reference to the [0,100] range from the javadoc on Task.getPriority() and Task.setPriority().

Re: Task Priority values

frederikherema1 — Mon, 04 Mar 2013 14:56:43 GMT

Duely noted, will be fixed in 5.13 (too late for 5.12 now) -> http://jira.codehaus.org/browse/ACT-1594