topic Re: Job Retry Strategy not being triggered when doCommit fails in Alfresco Archive

Job Retry Strategy not being triggered when doCommit fails

melentye — Thu, 13 Jun 2013 12:26:15 GMT

Hi,I'm using JtaProcessEngineConfiguration in Activiti Engine 5.12 to execute a process with a java service task with async=true attribute. Service task is executed fine (without exceptions) but due to the application logic issue, when transaction is committed in JtaTransactionInterceptor.doCommit m

Re: Job Retry Strategy not being triggered when doCommit fails

jbarrez — Mon, 17 Jun 2013 14:01:47 GMT

hmmm it sure does seems like a bug if I understand you correctly.
But testing it is tricky: how can I force an exception in the .doCommit …

And secondly, how could that lead to an infinite loop? I tried to see how that would work in the code, but couldnt quite get it.

so

1) yes, most likely

2) That will be tricky to implement, as you notice yourself. But I do wonder if it is also the same for the Spring transaction and regular transaction calls … so if we can prove it with a unit test, we can start looking for a generic solution.

Re: Job Retry Strategy not being triggered when doCommit fails

melentye — Tue, 18 Jun 2013 14:01:53 GMT

it will take me some time to come up with a distilled test case

in general situation can be reproduced with java service task uses JPA to store an entity to the database but this insert violates the unique constraints. Depending on the exact way how storing operation is realized and on JPA provider, you might get an exception during the execution of java delegate or later during the commit. With latest stable version of hibernate I get an exception on commit here (I don't do any flushes or anything like this in the logic of java delegate).

the infinite loop happens because number of retries is never decreased I guess, so JobExecutor just keeps picking up the job after a certain wait timeout.

Re: Job Retry Strategy not being triggered when doCommit fails

jbarrez — Wed, 19 Jun 2013 09:44:04 GMT

hmmm now i understand better, and why it fails. Thanks for that

would be good if you can get a unit test for this.