topic Re: Link to content or Discussions, possible bug? in Alfresco Archive

Link to content or Discussions, possible bug?

guito4you — Mon, 24 Sep 2007 07:07:45 GMT

When a link is removed, the file to which it points, remains unaffected (it seems ok).Conversely, if you remove the original file, the link become orphans and take the next behaivor:1. The browser show the next message in red: "A system error happened during the operation: NodeRef must be supplied f

Re: Link to content or Discussions, possible bug?

kevinr — Wed, 26 Sep 2007 11:19:51 GMT

It is a bug and was fixed in 2.1E

Thanks,

Kevin

Re: Link to content or Discussions, possible bug?

guito4you — Wed, 26 Sep 2007 11:41:09 GMT

I think I've Alfresco Enterprise 2.1 as you can see in my alfresco.log file:

Alfresco started (Enterprise Network): Current version 2.1.0 (112) schema 73 - Installed version 2.1.0 (112) schema 73

Thanks

Re: Link to content or Discussions, possible bug?

kevinr — Wed, 26 Sep 2007 12:09:20 GMT

OK. The bug that was fixed was that if the destination of space/file link was removed, it was impossible to browse in the space containing the link. Does that work for you? The error you mention:
"A system error happened during the operation: NodeRef must be supplied for creation of a Node".
What exactly are your steps to get the error?

Thanks,

Kevin

Re: Link to content or Discussions, possible bug?

guito4you — Wed, 26 Sep 2007 12:25:29 GMT

Steps to get the error:

1. Upload a new file (for instance, testfile.pdf) into your home space.

2. Create a new space (for instance (Test Folder) into your home space in order tu put the future link.

3. Copy the file testfile.pdf in your clipboard and then create a link into the Test Folder.

4. Delete testfile.pdf (original file, not destination!!)

After that, you can see the error: "A system error happened during the operation: NodeRef must be supplied for creation of a Node" into the "Test Folder".

If you try to upload new content o create new space into "test Folder" the browser doesnt' show anything, only show the above error.

Anyway, you can acces to the new content by search or by navigator (left frame)

If you have another spaces into "Test Folder" created before "broken link", it's possible acces by navigation left frame, but impossible to see into the "main frame"

Note: Links to "Discussions" and links to Folders has the same behaivor (avobe explained)

Conversely, if you remove the destination link, everything works fine.

Thanks

Re: Link to content or Discussions, possible bug?

kevinr — Thu, 27 Sep 2007 14:39:45 GMT

I have tested and confirmed. Yes the bug is present The issue that was fixed for 2.1E has indeed been fixed - however it looks like a different change in 2.1E has caused a very similar bug to occur.

I have raised JIRA item for it and will look at it ASAP:
http://issues.alfresco.com/browse/AWC-1605

Thanks,

Kevin

Re: Link to content or Discussions, possible bug?

kevinr — Thu, 27 Sep 2007 14:54:38 GMT

Fixed: http://issues.alfresco.com/browse/AWC-1605


Index: BrowseBean.java
===================================================================
— BrowseBean.java     (revision 6874)
+++ BrowseBean.java     (working copy)
@@ -780,7 +780,7 @@
                   node = new MapNode(nodeRef, this.nodeService, fileInfo.getProperties());
                   // only display the user has the permissions to navigate to the target of the link
                   NodeRef destRef = (NodeRef)node.getProperties().get(ContentModel.PROP_LINK_DESTINATION);
-                  if (new Node(destRef).hasPermission(PermissionService.READ) == true)
+                  if (destRef != null && new Node(destRef).hasPermission(PermissionService.READ) == true)
                   {
                      node.addPropertyResolver("url", this.resolverLinkUrl);
                      node.addPropertyResolver("webdavUrl", this.resolverLinkWebdavUrl);
@@ -799,7 +799,7 @@
                   node = new MapNode(nodeRef, this.nodeService, fileInfo.getProperties());
                   // only display the user has the permissions to navigate to the target of the link
                   NodeRef destRef = (NodeRef)node.getProperties().get(ContentModel.PROP_LINK_DESTINATION);
-                  if (new Node(destRef).hasPermission(PermissionService.READ) == true)
+                  if (destRef != null && new Node(destRef).hasPermission(PermissionService.READ) == true)
                   {
                      node.addPropertyResolver("icon", this.resolverSpaceIcon);
                      node.addPropertyResolver("smallIcon", this.resolverSmallIcon);
‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Thanks,

Kevin

Re: Link to content or Discussions, possible bug?

olex — Tue, 27 Nov 2007 11:21:51 GMT

Steps to get the error:
1. Upload a new file (for instance, testfile.pdf) into your home space.
2. Create a new space (for instance (Test Folder) into your home space in order tu put the future link.
3. Copy the file testfile.pdf in your clipboard and then create a link into the Test Folder.
4. Delete testfile.pdf (original file, not destination!!)
After that, you can see the error: "A system error happened during the operation: NodeRef must be supplied for creation of a Node" into the "Test Folder".

This seems fixed - there is no error.

But destination link (with PROP_LINK_DESTINATION = null)
still exists into "Test Folder": it's visible using "webdav" style URL for instance
or via custom space traverse code.

Re: Link to content or Discussions, possible bug?

olex — Tue, 27 Nov 2007 11:29:59 GMT

Steps to get the error:
1. Upload a new file (for instance, testfile.pdf) into your home space.
2. Create a new space (for instance (Test Folder) into your home space in order tu put the future link.
3. Copy the file testfile.pdf in your clipboard and then create a link into the Test Folder.
4. Delete testfile.pdf (original file, not destination!!)
After that, you can see the error: "A system error happened during the operation: NodeRef must be supplied for creation of a Node" into the "Test Folder".
This seems fixed - there is no error.

But destination link (with PROP_LINK_DESTINATION = null)
still exists into "Test Folder": it's visible using "webdav" style URL for instance
or via custom space traverse code.

BTW, there is one more issue with links via WebDAV: if you click on TYPE_FILELINK item in browser
(using URL like http://localhost:8080/alfresco/webdav/Test/Link%20to%20test.wav.url),
org.alfresco.repo.webdav.GetMethod returns
"The node's content is missing" error instead of content data.

I think "executeImpl" method should provide something like this:

            ContentReader reader = null;
            
            if (nodeInfo.isLink())
            {
              reader = fileFolderService.getReader(nodeInfo.getLinkNodeRef());
            }
            else
            {
              reader = fileFolderService.getReader(nodeInfo.getNodeRef());
            }
‍‍‍‍‍‍‍‍‍‍‍

Also I think it's quite useful to show original content length for "links" (not 0 as now) in UI.

Thanks

Re: Link to content or Discussions, possible bug?

kevinr — Tue, 27 Nov 2007 11:49:12 GMT

You are correct - i will make the code change as you have suggested.

Thanks,

Kevin

Re: Link to content or Discussions, possible bug?

olex — Tue, 27 Nov 2007 12:21:32 GMT

You are correct - i will make the code change as you have suggested.

Thanks,

Kevin

Thank you, Kevin - it will be great!

And one more WebDAV and links related thing: it seems like MS WebDAV
client doesn't show links.

Thanks,
Oleg

Re: Link to content or Discussions, possible bug?

hilal_aslan — Wed, 28 Jun 2017 07:42:11 GMT

Hi olex, I need some help about create link using rest api,

I m using Alfresco Community 5.2. I want to create link a file(this file is in another site) to site by using REST API. But I can not find any document about this issue.

I m clicking "copy to" on myfiles folder or any site folder. And after that, it is appear a button called "create link". By clicking this button, I can create link for this document to any place. But now, I want to make this process (create link) with rest api.